I'm a member of the Debian kernel team, not specifically interested in
VServer but looking at it as part of the maintenance of our current
stable release (Debian 6.0 'squeeze').
I see there's a new VServer version (vs2.3.0.36.29.7) based on stable
release 2.6.32.41. This is appreciated, and I'm intending to update our
VServer packages accordingly.
However, after comparing this with the previous version
(vs2.3.0.36.29.6) I noticed this change:
> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index ca81fce..c140532 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -627,10 +627,6 @@ SYSCALL_DEFINE4(ptrace, long, request, long, pid, long, addr, long, data)
> goto out;
> }
>
> - ret = -EPERM;
> - if (!vx_check(vx_task_xid(child), VS_WATCH_P | VS_IDENT))
> - goto out_put_task_struct;
> -
> if (request == PTRACE_ATTACH) {
> ret = ptrace_attach(child);
> /*
Was this removal intentional? Was this check redundant with those in
__ptrace_may_access()?
Secondly, following commit 3c77f845722158206a7209c45ccddc264d19319c
which was backported into 2.6.32.37, you need to make the new
acct_arg_size() function call vx_vmpages_add(). Patch for this is
attached.
Finally, I couldn't find changelogs for VServer patches. Where can I
find this information?
Ben.
-- Ben Hutchings It is easier to write an incorrect program than to understand a correct one.